browser detection php script, 'funwebproducts' detected as mobile
pmin00
Status: New User - Welcome
Joined: 12 Dec 2011
Posts: 3
Reply Quote
Bug report:

In the browser detection php script just
downloaded from this site:

Many IE browsers have 'funwebproducts' installed,
which shows in the user agent string.

The 'check_is_mobile' function checks for 'webpro',
so will return that this user agent is mobile, when it isn't.
Back to top
techAdmin
Status: Site Admin
Joined: 26 Sep 2003
Posts: 3735
Location: East Coast, West Coast? I know it's one of them.
Reply Quote
Please post a full useragent string of the useragent that is being incorrectly identified, otherwise I have no data. For now I'll double check the webpro string.

Isn't funwebproducts basically spyware? Maybe I should add another category to the browser detection script, spyware infected systems.
Back to top
techAdmin
Status: Site Admin
Joined: 26 Sep 2003
Posts: 3735
Location: East Coast, West Coast? I know it's one of them.
Reply Quote
That's fixed in 5.4.1

thanks for the bug report, easy fix, replace search for webpro with webpro/
Back to top
pmin00
Status: New User - Welcome
Joined: 12 Dec 2011
Posts: 3
Reply Quote
:: techAdmin wrote ::
That's fixed in 5.4.1

thanks for the bug report, easy fix, replace search for webpro with webpro/


No problem.
It's one of those little things, I fixed it too, but if no-one reports it then the bug will stay in..

For reference, here's a sample user agent string:
Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; FunWebProducts; .NET CLR 1.1.4322; .NET CLR 2.0.50727; InfoPath.1)

About 1% of the IE hits I get have FunWebProducts in there.
Back to top
techAdmin
Status: Site Admin
Joined: 26 Sep 2003
Posts: 3735
Location: East Coast, West Coast? I know it's one of them.
Reply Quote
thanks for the report. I actually didn't properly fix it, just added in a little hack so msie wouldn't register true as mobile, given there are a lot more msie users with funweb whatever than there are webpro browser users, that's a fine thing to do.

So the webpro browser version number will be wrong until I fix the actual core of the issue, which shouldn't be that hard , and won't change anything you see externally, ideally anyway, heh..
Back to top
pmin00
Status: New User - Welcome
Joined: 12 Dec 2011
Posts: 3
Reply Quote
:: techAdmin wrote ::
given there are a lot more msie users with funweb whatever than there are webpro browser users, that's a fine thing to do.

Quite. My current numbers are:
IE: 39%
mobile browsers: 2.5%
webpro: 0.000000000000%

:-)
Back to top
Display posts from previous:   

All times are GMT - 8 Hours